Skip to content

fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they start #16035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they start #16035

merged 3 commits into from
May 29, 2025

Conversation

raythurnvoid
Copy link
Contributor

Fix the issue reported at #14732

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@raythurnvoid
fix: transitions might render animated elements without animation sty…
03c6408 
…les applied for the duration of some rendering frames when they starts
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2025

⚠️ No Changeset found

Latest commit: 03c6408

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raythurnvoid
Copy link
Contributor Author

I'm unsure this can be tested if not manually

@raythurnvoid raythurnvoid changed the title fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they starts fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they start May 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16035

Rich-Harris
Rich-Harris approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you! agree that testing such things is prohibitively difficult, but having the comment there should make regressions unlikely

@Rich-Harris Rich-Harris merged commit ff72dd2 into sveltejs:main May 29, 2025
@github-actions github-actions bot mentioned this pull request May 29, 2025
Merged
@dummdidumm dummdidumm mentioned this pull request May 29, 2025
Closed
@raythurnvoid raythurnvoid mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raythurnvoid @Rich-Harris